You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The router allows specifying different hostname for specific routes, and handles this internally by string concatenation of host and path into uri, confusing app.url_for into creating invalid URLs.
Ultimately it would be more sensible to keep URL and path separately in Router objects, but as a workaround to the mentioned bug report, this is now handled in url_for which uses any route-provided host where SERVER_NAME would otherwise be used.
Adds test_url_for.py to avoid regressions, and to allow for more comprehensive testing of the said function, which doesn't seem to be currently tested properly.
I cannot reproduce that test failure on my own system, and it is not quite obvious from the output what went wrong. Is this related to this patch or a problem with the CI pipeline?
* Cherry pick PRs to backport to 19.12LTS
Includes commits from:
#1762#1764#1789
* Fix type annotation issue; run black and isort
* Update Makefile
Co-authored-by: Ashley Sommer <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The router allows specifying different hostname for specific routes, and handles this internally by string concatenation of host and path into uri, confusing
app.url_forinto creating invalid URLs.Ultimately it would be more sensible to keep URL and path separately in Router objects, but as a workaround to the mentioned bug report, this is now handled in
url_forwhich uses any route-provided host whereSERVER_NAMEwould otherwise be used.Adds
test_url_for.pyto avoid regressions, and to allow for more comprehensive testing of the said function, which doesn't seem to be currently tested properly.Fixes issue #1788